Prefer native WAV decoding before SDL_sound#2066
Open
Tutez64 wants to merge 1 commit into
Open
Conversation
Try Lime's native WAV decoder before SDL_sound for eager audio buffer loading. This avoids SDL_sound introducing artifacts for some PCM WAV files loaded from bytes, while keeping SDL_sound as a fallback for formats or WAV variants not handled by the native decoder.
Member
|
Would prefer to find out what is causing the audio noise rather than papering over the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prefer Lime's native WAV decoder before SDL_sound when eagerly loading audio buffers from files or bytes.
Rationale
Some PCM WAV sound effects decoded through SDL_sound first can produce audible startup artifacts when loaded via
AudioBuffer.fromBytes(). The same assets decode and play correctly when Lime's nativeWAV::Decode()path is used first.For plain PCM WAV files, the native decoder is the more direct path: it reads the RIFF/WAVE chunks and copies the sample data without routing through SDL_sound conversion. SDL_sound remains available as a fallback for formats or WAV variants that the native decoder does not support.
Repro
LimeWavSdlSoundArtifactRepro.zip