Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

NetlistResources Controller Refactor with Integration Testing for OpenTSDB#320

Merged
adamkorynta merged 7 commits into
opendcs:feature/task_cwms_supportfrom
zack-rma:feature/task_cwms_support_netlist_resources_it
Jan 30, 2025
Merged

NetlistResources Controller Refactor with Integration Testing for OpenTSDB#320
adamkorynta merged 7 commits into
opendcs:feature/task_cwms_supportfrom
zack-rma:feature/task_cwms_support_netlist_resources_it

Conversation

@zack-rma

@zack-rma zack-rma commented Jan 8, 2025

Copy link
Copy Markdown
Collaborator

Problem Description

Fixes #238.

Solution

Adds integration testing coverage to refactored NetlistResources.

how you tested the change

Integration testing included.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@zack-rma

zack-rma commented Jan 8, 2025

Copy link
Copy Markdown
Collaborator Author

Netlist storage/retrieval bug currently under investigation

@zack-rma

zack-rma commented Jan 8, 2025

Copy link
Copy Markdown
Collaborator Author

Requires Toolkit changes found here: adamkorynta/opendcs#5

@zack-rma zack-rma changed the title NetlistResources Integration Testing for OpenTSDB NetlistResources Controller Refactor with Integration Testing for OpenTSDB Jan 10, 2025
@zack-rma zack-rma self-assigned this Jan 16, 2025
@zack-rma zack-rma force-pushed the feature/task_cwms_support_netlist_resources_it branch from 73611c2 to c6a8a66 Compare January 17, 2025 01:10
@zack-rma zack-rma marked this pull request as ready for review January 17, 2025 22:30
@zack-rma zack-rma requested a review from rma-rripken January 17, 2025 22:32
Comment thread opendcs-rest-api/src/main/java/org/opendcs/odcsapi/res/NetlistResources.java Outdated
@zack-rma zack-rma requested a review from adamkorynta January 29, 2025 18:23
@zack-rma zack-rma force-pushed the feature/task_cwms_support_netlist_resources_it branch from d7f4b1f to 03849a3 Compare January 30, 2025 22:59
@sonarqubecloud

Copy link
Copy Markdown

@adamkorynta adamkorynta merged commit e099a7f into opendcs:feature/task_cwms_support Jan 30, 2025
@zack-rma zack-rma removed their assignment Jan 31, 2025
adamkorynta pushed a commit that referenced this pull request Mar 13, 2025
…nTSDB (#320)

Implemented NetlistResources Controller refactor with integration testing
adamkorynta pushed a commit that referenced this pull request Mar 24, 2025
…nTSDB (#320)

Implemented NetlistResources Controller refactor with integration testing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

OpenTSDB: Create Integration Tests for NetlistResouces controller Refactor NetlistResources controller

3 participants