Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

ConfigResources Controller Refactor with Integration Testing for OpenTSDB#313

Merged
adamkorynta merged 6 commits into
opendcs:feature/task_cwms_supportfrom
zack-rma:feature/task_cwms_support_config_resources_it
Jan 30, 2025
Merged

ConfigResources Controller Refactor with Integration Testing for OpenTSDB#313
adamkorynta merged 6 commits into
opendcs:feature/task_cwms_supportfrom
zack-rma:feature/task_cwms_support_config_resources_it

Conversation

@zack-rma

@zack-rma zack-rma commented Jan 1, 2025

Copy link
Copy Markdown
Collaborator

Problem Description

Fixes #235.

Solution

Implements integration testing against OpenTSDB.

how you tested the change

Integration tests included.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@zack-rma

zack-rma commented Jan 1, 2025

Copy link
Copy Markdown
Collaborator Author

The current implementation of readConfig returns an empty DTO, which is under investigation

@zack-rma zack-rma changed the title Integration Testing for ConfigResources ConfigResources Controller Refactor with Integration Testing for OpenTSDB Jan 16, 2025
@zack-rma zack-rma self-assigned this Jan 16, 2025
@zack-rma

Copy link
Copy Markdown
Collaborator Author

Requires Toolkit changes found here: adamkorynta/opendcs#12

Retrieval bugs resolved.

@zack-rma zack-rma marked this pull request as ready for review January 16, 2025 22:42
@zack-rma zack-rma requested a review from rma-rripken January 16, 2025 22:42
@zack-rma zack-rma force-pushed the feature/task_cwms_support_config_resources_it branch from 58e88f5 to 3d65543 Compare January 29, 2025 18:56
@zack-rma zack-rma requested a review from adamkorynta January 30, 2025 22:59
@sonarqubecloud

Copy link
Copy Markdown

@adamkorynta adamkorynta merged commit a5142fa into opendcs:feature/task_cwms_support Jan 30, 2025
@zack-rma zack-rma removed their assignment Jan 31, 2025
adamkorynta pushed a commit that referenced this pull request Mar 13, 2025
…TSDB (#313)

Implemented ConfigResources Controller refactor, ConfigSensor mapping
adamkorynta pushed a commit that referenced this pull request Mar 24, 2025
…TSDB (#313)

Implemented ConfigResources Controller refactor, ConfigSensor mapping
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

OpenTSDB: Create Integration Tests for ConfigResources controller Refactor ConfigResources controller

3 participants