This repository was archived by the owner on Apr 1, 2026. It is now read-only.
PresentationResources Controller Refactor with Integration Testing for OpenTSDB#285
Merged
adamkorynta merged 3 commits intoJan 29, 2025
Conversation
Collaborator
Author
|
Will need new OpenDCS DAI method implementation for full feature support |
6 tasks
|
zack-rma
force-pushed
the
feature/task_cwms_support_presentation_resources
branch
from
c0151b1 to
5a3b2fe
Compare
Collaborator
Author
|
Requires Toolkit method implementations found here: adamkorynta/opendcs#8 |
zack-rma
changed the title
rma-rripken
reviewed
Jan 14, 2025
rma-rripken
approved these changes
Jan 14, 2025
zack-rma
modified the milestones:
F0215 Task 2.1 - Refactor controllers,
F0215 Task 2.2 - OpenTSDB: Integration Testing Controllers
rma-rripken
approved these changes
Jan 20, 2025
rma-rripken
approved these changes
Jan 20, 2025
…g, supports new Toolkit methods
zack-rma
force-pushed
the
feature/task_cwms_support_presentation_resources
branch
from
c129f97 to
6498819
Compare
|
This was
linked to
issues
Jan 29, 2025
zack-rma
added a commit
to zack-rma/rest_api
that referenced
this pull request
Jan 30, 2025
…r OpenTSDB (opendcs#285) Refactored PresentationResources Controller, added integration testing, supports new Toolkit methods
adamkorynta
pushed a commit
that referenced
this pull request
Mar 13, 2025
…r OpenTSDB (#285) Refactored PresentationResources Controller, added integration testing, supports new Toolkit methods
adamkorynta
pushed a commit
that referenced
this pull request
Mar 24, 2025
…r OpenTSDB (#285) Refactored PresentationResources Controller, added integration testing, supports new Toolkit methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
Fixes #229.
Fixes #241.
Solution
Replaces DAO usage with OpenDCS DAI implementations.
how you tested the change
Unit tests included.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.