Clarify that whiteout filenames require a non-empty basename#1314
Merged
tianon merged 1 commit intoMay 7, 2026
Merged
Conversation
mahitha-ada
requested review from
cyphar,
jonjohnsonjr,
sajayantony,
stevvooe,
sudo-bmitch and
tianon
as code owners
sudo-bmitch
requested changes
Apr 16, 2026
Contributor
|
Thanks for the updates @mahitha-ada . Please squash the commits on this. |
Signed-off-by: Mahitha Adapa <mahitha.ada@gmail.com> Update layer.md Co-authored-by: Brandon Mitchell <git@bmitch.net> Signed-off-by: Mahitha Adapa <mahitha.ada@gmail.com> Update layer.md Co-authored-by: Brandon Mitchell <git@bmitch.net> Signed-off-by: Mahitha Adapa <mahitha.ada@gmail.com>
mahitha-ada
force-pushed
the
clarify-whiteout-basename-requirement
branch
from
7060bc9 to
b9060a3
Compare
prince200212
approved these changes
Apr 25, 2026
tianon
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1301.
Clarifies in the whiteout specification that a
.wh.prefix MUST befollowed by a non-empty basename. The current spec does not explicitly
address the edge case of a bare
.wh.entry (with no basename), whichleads to inconsistent behavior across implementations — for example,
containerd rejects it with "invalid whiteout name: .wh." while other
runtimes may handle it unpredictably.
This change:
.wh.entriesSigned-off-by: Mahitha Adapa mahitha.ada@gmail.com