feat: add intent parameter to distinguish file preview from download#2281
Open
yuuhikaze wants to merge 1 commit intoopencloud-eu:mainfrom
Open
feat: add intent parameter to distinguish file preview from download#2281yuuhikaze wants to merge 1 commit intoopencloud-eu:mainfrom
yuuhikaze wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
- Add 'intent' parameter support to getFileUrl() with 'preview' or 'download' values - Update all viewer apps to pass intent: 'preview': - Preview app (images, videos, audio) - PDF viewer - EPUB reader - Text editor - Add intent: 'download' to download composable - Include intent in preview service thumbnail URLs - Modify addIntentToUrl() to append intent as query parameter - Pass X-OC-Intent header for inline file access This enables the audit service to distinguish between file views and downloads for compliance tracking, with intent metadata propagating through HTTP headers and query parameters to the backend services. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add client-side intent signaling to distinguish between file previews and downloads for audit logging. This enables fine-grained access control policies (e.g., ban downloads of MP4/PDF while allowing previews).
Purpose
Enable OpenCloud to audit and control file access patterns by distinguishing:
This allows organizations to implement policies like:
Microsoft 365 implements similar intent signaling, making this a standard pattern for collaborative platforms.
Changes
intentparameter ('preview'|'download') togetFileUrl()intent: 'download'?intent=preview|downloadX-OC-Intentintent: 'preview'Testing Status
Notes