chore(deps): update dependency vite to v8#390
Open
renovate[bot] wants to merge 2 commits intomainfrom
Open
Conversation
07fe16f to
733267f
Compare
733267f to
5fb9857
Compare
Vite 8 uses Rolldown which replaces `import.meta` with `{}` in UMD
format. This triggers warnings in three apps:
- web-app-importer: Vite preload hints for @UPPY dynamic imports (no-op
since UMD inlines all chunks)
- web-app-json-viewer: Vite preload hint for vanilla-picker dynamic
import (same reason)
- web-app-unzip: @zip.js/zip.js baseURI config (overridden by explicit
workerURI in useUnzipAction.ts)
All cases are harmless. Each app explicitly suppresses the warning with
a comment explaining why.
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
7.3.1→8.0.2Breaking change: AMD format no longer supported
Vite 8 uses Rolldown instead of Rollup. Rolldown does not support the
amdoutput format (rolldown#2528).Migration to UMD
The extension-sdk has been updated to use
umdinstead ofamd. UMD includes an AMD branch, so extensions loaded via RequireJS continue to work via thedefine()path.Key changes in the extension-sdk:
format: 'amd'→format: 'umd'(withnameandglobalsfor the UMD wrapper)chunkFileNames(UMD does not support code splitting)completeUmdCurrentScriptPluginto fixdocument.currentScriptresolution for async module loaders (see below)No code splitting with UMD
UMD bundles everything into a single file. Dynamic
import()calls are automatically inlined. This means:document.currentScriptpolyfillVite's UMD URL resolution uses
document.currentScriptfor relative asset paths (?urlimports). However,document.currentScriptisnullwhen RequireJS calls the factory callback asynchronously, causing incorrect URL resolution.The extension-sdk includes a plugin that captures
document.currentScriptat the top of the script while it's still valid. This fix has been upstreamed to Vite.EMPTY_IMPORT_METAwarningsRolldown replaces
import.metawith{}in UMD format. Three apps trigger this warning — all cases have been verified as harmless and are explicitly suppressed with per-app comments:@zip.js/zip.jsbaseURI config (overridden by explicitworkerURI)Dependencies
Requires updated
@opencloud-eu/extension-sdkwith UMD support (not yet released).Test plan
pnpm build --mode developmentbuilds all 11 extensions without errors?urlasset imports resolve correctly at runtime with RequireJS🤖 Generated with Claude Code