adapt pipeline for prod releases#2553
adapt pipeline for prod releases#2553dragonchaser wants to merge 2 commits intoopencloud-eu:mainfrom
Conversation
Signed-off-by: Christian Richter <c.richter@opencloud.eu> # Conflicts: # .woodpecker.star
5c55272 to
c6af14a
Compare
3d8f5db to
5d96e2c
Compare
1ba3f9a to
b566efb
Compare
4fed263 to
39dec59
Compare
910ccac to
fee5f71
Compare
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
|
|
Please merge as is, this will never get green because of set test labels. |
we can't merge it until getting green |
|
@ScharfViktor I did, otherwise I would not be able to test the functionality. |
| event["pull_request"], | ||
| { | ||
| "evaluate": 'CI_COMMIT_PULL_REQUEST_LABELS contains "production_release"', | ||
| }, |
There was a problem hiding this comment.
This does not work, because If at least one of the conditions in the when block evaluate to true the step is executed, otherwise it is skipped. see: https://woodpecker-ci.org/docs/usage/workflow-syntax#when---conditional-execution
Also, the linter shows a warning:

A condition is evaluated to true if all sub-conditions are true.
| event["pull_request"], | |
| { | |
| "evaluate": 'CI_COMMIT_PULL_REQUEST_LABELS contains "production_release"', | |
| }, | |
| { | |
| "event": "pull_request", | |
| "evaluate": 'CI_COMMIT_PULL_REQUEST_LABELS contains "production_release"', | |
| } |
or
| event["pull_request"], | |
| { | |
| "evaluate": 'CI_COMMIT_PULL_REQUEST_LABELS contains "production_release"', | |
| }, | |
| { | |
| "evaluate": CI_PIPELINE_EVENT == "pull_request" && CI_COMMIT_PULL_REQUEST_LABELS contains "production_release"', | |
| }, |




This PR splits the check_version pipeline into two steps, the step for detecting leftover
%%NEXT_PRODUCTION_VERSION%%placeholders only is run when the labelproduction_releaseis set for the PR./cc @ScharfViktor && @individual-it