Skip to content

adapt pipeline for prod releases#2553

Open
dragonchaser wants to merge 2 commits intoopencloud-eu:mainfrom
dragonchaser:adapt_pipeline
Open

adapt pipeline for prod releases#2553
dragonchaser wants to merge 2 commits intoopencloud-eu:mainfrom
dragonchaser:adapt_pipeline

Conversation

@dragonchaser
Copy link
Copy Markdown
Member

@dragonchaser dragonchaser commented Mar 31, 2026

This PR splits the check_version pipeline into two steps, the step for detecting leftover %%NEXT_PRODUCTION_VERSION%% placeholders only is run when the label production_release is set for the PR.

/cc @ScharfViktor && @individual-it

Signed-off-by: Christian Richter <c.richter@opencloud.eu>

# Conflicts:
#	.woodpecker.star
@dragonchaser dragonchaser added Type:Maintenance E.g. technical debt, packaging, etc. production_release labels Mar 31, 2026
@dragonchaser dragonchaser force-pushed the adapt_pipeline branch 2 times, most recently from 3d8f5db to 5d96e2c Compare March 31, 2026 12:41
@dragonchaser dragonchaser force-pushed the adapt_pipeline branch 2 times, most recently from 1ba3f9a to b566efb Compare March 31, 2026 12:44
@dragonchaser dragonchaser changed the title adapt pipeline for prod releases Release adapt pipeline for prod releases Mar 31, 2026
@dragonchaser dragonchaser force-pushed the adapt_pipeline branch 4 times, most recently from 4fed263 to 39dec59 Compare March 31, 2026 12:52
@dragonchaser dragonchaser changed the title Release adapt pipeline for prod releases 🎉 Release adapt pipeline for prod releases Mar 31, 2026
@dragonchaser dragonchaser force-pushed the adapt_pipeline branch 2 times, most recently from 910ccac to fee5f71 Compare March 31, 2026 13:05
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
@sonarqubecloud
Copy link
Copy Markdown

@dragonchaser dragonchaser changed the title 🎉 Release adapt pipeline for prod releases adapt pipeline for prod releases Mar 31, 2026
@dragonchaser dragonchaser marked this pull request as ready for review March 31, 2026 13:24
@dragonchaser
Copy link
Copy Markdown
Member Author

Please merge as is, this will never get green because of set test labels.

@ScharfViktor
Copy link
Copy Markdown
Contributor

Please merge as is, this will never get green because of set test labels.

we can't merge it until getting greenall-checks-finished

@ScharfViktor
Copy link
Copy Markdown
Contributor

I see your last running
Screenshot 2026-03-31 at 16 14 08

to get green you need run CI without 🎉 Release in the title and label production_release
try to force push

@dragonchaser
Copy link
Copy Markdown
Member Author

@ScharfViktor I did, otherwise I would not be able to test the functionality.

Comment on lines +1857 to +1860
event["pull_request"],
{
"evaluate": 'CI_COMMIT_PULL_REQUEST_LABELS contains "production_release"',
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work, because If at least one of the conditions in the when block evaluate to true the step is executed, otherwise it is skipped. see: https://woodpecker-ci.org/docs/usage/workflow-syntax#when---conditional-execution

Also, the linter shows a warning:
Image

A condition is evaluated to true if all sub-conditions are true.

Suggested change
event["pull_request"],
{
"evaluate": 'CI_COMMIT_PULL_REQUEST_LABELS contains "production_release"',
},
{
"event": "pull_request",
"evaluate": 'CI_COMMIT_PULL_REQUEST_LABELS contains "production_release"',
}

or

Suggested change
event["pull_request"],
{
"evaluate": 'CI_COMMIT_PULL_REQUEST_LABELS contains "production_release"',
},
{
"evaluate": CI_PIPELINE_EVENT == "pull_request" && CI_COMMIT_PULL_REQUEST_LABELS contains "production_release"',
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:Maintenance E.g. technical debt, packaging, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants