Open
Conversation
Member
|
Hey, thank you very much for your PR. Before we can progress it, please take a moment and describe what you want to achieve with it. What is better with your PR? Also I tried to compile it on my system, and I needed this patch to actually build it: diff --git a/src/gui/newwizard/pages/syncfoldersetupwizardpage.cpp b/src/gui/newwizard/pages/syncfoldersetupwizardpage.cpp
index d02f28744..e34225762 100644
--- a/src/gui/newwizard/pages/syncfoldersetupwizardpage.cpp
+++ b/src/gui/newwizard/pages/syncfoldersetupwizardpage.cpp
@@ -7,9 +7,10 @@
namespace OCC::Wizard {
-SyncFolderSetupWizardPage::SyncFolderSetupWizardPage(const QString &defaultSyncFolder, QWidget *parent)
- : _ui(std::make_unique<Ui::SyncFolderSetupWizardPage>())
+SyncFolderSetupWizardPage::SyncFolderSetupWizardPage(const QString &defaultSyncFolder, QWidget*parent)
+ : _ui(new Ui::SyncFolderSetupWizardPage)
{
+ Q_UNUSED(parent)
_ui->setupUi(this);
_ui->syncFolderLineEdit->setText(QDir::toNativeSeparators(defaultSyncFolder));
@@ -17,7 +18,6 @@ SyncFolderSetupWizardPage::SyncFolderSetupWizardPage(const QString &defaultSyncF
auto dialog = new QFileDialog(this, tr("Select the sync folder location"), defaultSyncFolder);
dialog->setFileMode(QFileDialog::Directory);
dialog->setOption(QFileDialog::ShowDirsOnly);
- dialog->setOption(QFileDialog::DontCreateDirectories);
connect(dialog, &QFileDialog::fileSelected, this, [this](const QString &directory) {
_ui->syncFolderLineEdit->setText(QDir::toNativeSeparators(directory));
@@ -29,7 +29,6 @@ SyncFolderSetupWizardPage::SyncFolderSetupWizardPage(const QString &defaultSyncF
SyncFolderSetupWizardPage::~SyncFolderSetupWizardPage() noexcept
{
- delete _ui;
}
QString SyncFolderSetupWizardPage::syncFolder() const
diff --git a/src/gui/newwizard/pages/syncfoldersetupwizardpage.h b/src/gui/newwizard/pages/syncfoldersetupwizardpage.h
index fdd23fde4..2d90bf767 100644
--- a/src/gui/newwizard/pages/syncfoldersetupwizardpage.h
+++ b/src/gui/newwizard/pages/syncfoldersetupwizardpage.h
@@ -22,11 +22,8 @@ public:
QString syncFolder() const;
bool validateInput() const override;
-Q_SIGNALS:
- void contentChanged() override;
-
private:
- std::unique_ptr<Ui::SyncFolderSetupWizardPage> _ui;
+ std::unique_ptr<::Ui::SyncFolderSetupWizardPage> _ui;
};
} // OCC::WizardQt version 6.10.2 |
Author
|
I'll update the PR asap. When installed in a new system, the app creates its sync folder in the home (/Users/user/OpenCloud on macos or /home/OpenCloud on linux) by default, I wanted the user to be able to choose where to create the Sync folder during the app setup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.