feat(docs): insert images from public URLs#745
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 11, 2026, 12:21 AM ET / 04:21 UTC. Summary Reproducibility: not applicable. as a feature PR; the linked report provides a high-confidence reproduction of the existing enterprise Drive-sharing limitation rather than a current-main implementation bug in this branch. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Merge the validated direct-HTTPS source path while retaining the existing local upload/share/revoke workflow and its output contract unchanged. Do we have a high-confidence way to reproduce the issue? Not applicable as a feature PR; the linked report provides a high-confidence reproduction of the existing enterprise Drive-sharing limitation rather than a current-main implementation bug in this branch. Is this the best way to solve the issue? Yes. Passing a validated public HTTPS URI directly to the Docs API is the narrowest native solution and avoids introducing alternate Drive permission policies or persistent upload state. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 1cb9512e795b. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
docs insert-image --urlfor direct public HTTPS image insertion.--fileas the existing upload/share/revoke path and make the two sources mutually exclusive.--url.Fixes #675.
Validation
go test ./internal/cmd -run 'TestDocsInsertImage|TestDocsWrite_Markdown.*Image|TestDocsFindReplace_.*Image'make ciLive Proof
Ran the branch binary with
clawdbot@gmail.comagainst a disposable Google Doc using Google's public Docs icon URL.docs insert-image --url ... --width 96 --height 96succeeded.uploadedFileId.docs rawreturned an inline object with the samesourceUriand a 96 by 96 PT size.