feat(docs): style fenced markdown code blocks#724
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 11, 2026, 12:12 AM ET / 04:12 UTC. Summary Reproducibility: not applicable. as a conventional runtime failure: the linked report provides a concrete mode comparison, and exact-head live API readback verifies the proposed output. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Adopt and document one fenced-code visual contract for all Markdown write modes, explicitly approve this shared incremental-renderer change, and retain the focused field-and-range regression coverage. Do we have a high-confidence way to reproduce the issue? Not applicable as a conventional runtime failure: the linked report provides a concrete mode comparison, and exact-head live API readback verifies the proposed output. Is this the best way to solve the issue? Yes technically: updating the shared formatter is the narrowest maintainable implementation, provided maintainers explicitly accept the broader visual compatibility scope. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 7a289fe2cf70. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
fd89f24 to
00bab20
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper re-review |
|
🦞👀 Command router queued. I will update this comment with the next step. Re-review progress:
|
|
Sanitized proof for this PR:
go test -v ./internal/cmd -run 'TestMarkdownToDocsRequests_AppendBulletsAndCode|TestDocsWrite_MarkdownAppendUsesDocsFormatting|TestDocsWrite_MarkdownAppendStartsStyledBlocksOnFreshParagraph' -count=1
{"fields":"weightedFontFamily,foregroundColor","fontFamily":"Roboto Mono","fontWeight":400,"range":{"startIndex":1,"endIndex":19},"rgbHex":"#188038"}This verifies the generated Docs API text-style request for fenced Markdown code blocks includes |
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
00bab20 to
75df705
Compare
Summary
Fixes #676.
Scope note
This intentionally covers the local Docs API renderer used by append, tab-replace, range update, and markdown find-replace paths. Whole-document
docs write --replace --markdownstill uses Drive import, so maintainers should decide whether that remains separate issue scope.Validation
make ci75df70592fb1f807dfc5cc38c099991ad1113aa1Proof
Ran the exact branch binary against a disposable Google Doc using
clawdbot@gmail.com. After appending a multiline fenced code block,docs rawreadback returned:weightedFontFamily.fontFamily:Roboto MonoweightedFontFamily.weight:400#188038#f2f2f2The disposable document was moved to trash after verification.