test: add keyring backend validation and auth coverage#26
Closed
salmonumbrella wants to merge 3 commits into
Closed
test: add keyring backend validation and auth coverage#26salmonumbrella wants to merge 3 commits into
salmonumbrella wants to merge 3 commits into
Conversation
Adds ensureKeychainAccess check before OAuth flow to fail early when keychain is locked. Includes test to verify authorizeGoogle is not called when keychain check fails. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add table-driven tests for allowedBackendsFromEnv() - Add errInvalidKeyringBackend sentinel for testable error checking - Fix formatting alignment in auth.go and store.go 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
salmonumbrella
changed the title
Add blank lines before if/return statements per whitespace linter rules. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
steipete
added a commit
that referenced
this pull request
Jan 7, 2026
Collaborator
|
Landed on via bf0b75a (fix(secrets): normalize keyring backend values). Thanks @salmonumbrella! |
Collaborator
|
Landed on |
manascb1344
pushed a commit
to manascb1344/gogcli
that referenced
this pull request
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowedBackendsFromEnv()covering all backend options (auto, keychain, file, invalid)errInvalidKeyringBackendsentinel error for programmatic error checking witherrors.Is()Test Plan
errors.Is(err, errInvalidKeyringBackend)checksinternal/secretsimproved to 74.7%🤖 Generated with Claude Code