fix(auth): improve auth UI#20
Merged
steipete merged 10 commits intoDec 31, 2025
Merged
Conversation
Replace blocking time.Sleep with select statement using time.After and ctx.Done() so the 30-second post-success display period can be interrupted by context cancellation (Ctrl+C). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace duplicate newAuthLoginCmd() with Cobra alias on newAuthManageCmd(). Both commands had identical RunE logic calling googleauth.StartManageServer. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add the same 30-second countdown JavaScript that exists in success.html to success_new.html for consistency. The countdown shows "Closing in X seconds..." and updates to "You can close this window." when complete. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…constant Add a named constant for the 30-second display delay after OAuth success. This keeps the Go code and HTML templates in sync, with comments in the HTML pointing to the authoritative constant definition in oauth_flow.go. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace inline SVG icons with a reusable `.icon-github` CSS class that uses mask-image with a data URI. Each template now includes a comment noting the other files to update if the icon changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Merge success_new.html content/layout into success.html - Add animated gradient orbs from original success.html - Use Go template conditionals to handle both cases: - With email/services (account manager flow) - Without email (simple OAuth flow) - Delete redundant success_new.html - Rename renderSuccessPageNew to renderSuccessPageWithDetails - Update tests to cover both template modes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…irement 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Extract inline select block into waitPostSuccess function and add unit tests verifying context cancellation behavior for Ctrl+C support. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
|
Thank you, appreciate the help and cleanup! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
success_new.html)gog auth loginas alias forgog auth managewith documentation