-
Notifications
You must be signed in to change notification settings - Fork 286
Single line address instead of textareas in UI #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Single line address instead of textareas in UI #675
Conversation
3dd96ef to
e187c3d
Compare
commit 1176778 Author: anonymoususer72041 <247563575+anonymoususer72041@users.noreply.github.com> Date: Fri Dec 5 14:54:37 2025 +0100 Drop legacy address2 from candidates add form commit e187c3d Author: anonymoususer72041 <247563575+anonymoususer72041@users.noreply.github.com> Date: Fri Dec 5 10:52:02 2025 +0100 Use single-line address input in careers portal apply form commit 44320d6 Author: anonymoususer72041 <247563575+anonymoususer72041@users.noreply.github.com> Date: Fri Dec 5 09:04:02 2025 +0100 Use single-line address inputs for candidates, contacts and companies
RussH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this cleans up the UI, shrinking the address to a single line breaks formatting for international users (specifically in the UK). Addresses often require multiple lines for Suite/Floor/Business Center details before the street address. I recommend keeping the multi-line support or using a textarea.
|
Thanks for calling this out – agreed that UK/international addresses often need additional lines. At the same time, there are also regions where a single address line is the norm, so I’d like to avoid presenting a large textarea by default (especially for candidates), since that can imply "write a full postal block here". Instead of only keeping multi-line addresses as free-form text, I can re-introduce proper "Address Line 2" support end-to-end. On the recruiter-facing side, I’d make Address Line 2 optional. For the careers portal, I’d keep it optional as well, so you can use it in your template if need. Would you be happy with that approach? |
Summary
<input>fields for candidates, contacts and companies in the main UI.<input-address>placeholder in CareersUI.php so that it expands to a single-line<input>instead of a textarea-like field. The careers portal templates stored in the database are not modified by this PR.Motivation