Conversation
…built-in Split IPKGMenu, IPKGSource and IpkgInstaller (renamed IPKGInstaller) out of SoftwareManager/plugin.py into their own Screens/IPKGInstaller.py, and register the ipk file scanner as a built-in in Components/Scanner.py instead of via a WHERE_FILESCAN plugin descriptor, decoupling ipk handling from the SoftwareManager plugin being installed. MediaScanner/plugin.py now uses Tools.Notifications (showInfo, addModalNotification) instead of ChoiceBox/MessageBox directly, and drops the InfoBar.execing guard in partitionListChanged. Since MessageBox only returns the second element of a selected list entry (unlike ChoiceBox, which returns the whole entry), the scan-result list is now built as (description, (description, scanner, files, session, popup)) pairs so execute() still receives the full tuple it expects.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…built-in
Split IPKGMenu, IPKGSource and IpkgInstaller (renamed IPKGInstaller) out of SoftwareManager/plugin.py into their own Screens/IPKGInstaller.py, and register the ipk file scanner as a built-in in Components/Scanner.py instead of via a WHERE_FILESCAN plugin descriptor, decoupling ipk handling from the SoftwareManager plugin being installed.
MediaScanner/plugin.py now uses Tools.Notifications (showInfo, addModalNotification) instead of ChoiceBox/MessageBox directly, and drops the InfoBar.execing guard in partitionListChanged. Since MessageBox only returns the second element of a selected list entry (unlike ChoiceBox, which returns the whole entry), the scan-result list is now built as (description, (description, scanner, files, session, popup)) pairs so execute() still receives the full tuple it expects.