Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be6b872ca7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // TODO(jif) actual implementation | ||
| let outcome = WaitResult { | ||
| status: Default::default(), | ||
| timed_out: false, | ||
| }; |
There was a problem hiding this comment.
The new wait handler hard‑codes outcome to Default::default() and never consults session/thread state, so every call returns PendingInit with success: true regardless of whether the agent exists or has completed. This means callers waiting on a real agent can get a false “still running” success response, and missing agents are never reported because the NotFound branch is unreachable. That breaks collab workflows that rely on wait to block or to surface missing/finished agents.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is normal, not done yet
gt-oai
left a comment
gt-oai
left a comment
There was a problem hiding this comment.
looking forward to seeing this in action
| impl AgentControlHarness { | ||
| async fn new() -> Self { | ||
| let (home, config) = test_config().await; | ||
| let manager = ThreadManager::with_models_provider_and_home( |
There was a problem hiding this comment.
nit: would probably do a pass to inline 'SSA' variables like these
2 participants
No description provided.