Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

Update utils.py#64

Open
NomsterDude wants to merge 1 commit into
openai:masterfrom
NomsterDude:master
Open

Update utils.py#64
NomsterDude wants to merge 1 commit into
openai:masterfrom
NomsterDude:master

Conversation

@NomsterDude

Copy link
Copy Markdown

Removed the need to import math by implementing another method to calculate a sqrt.

Removed the need to import math by implementing another method to calculate a sqrt.
@sleroq

sleroq commented Jun 11, 2022

Copy link
Copy Markdown

But why?

@zaaachos

Copy link
Copy Markdown

But why?

he wanted to contribute to this code someway hahaha

@NomsterDude

Copy link
Copy Markdown
Author

But why?

Removes the need for an import and improves efficiency, even if not by much.

@MACHONEJ82 MACHONEJ82 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@NomsterDude

Copy link
Copy Markdown
Author

You didn't suggest any changes.

@gabrielnoal

Copy link
Copy Markdown

Hi guys, I was just looking some PR's to see if there was any new improvement and found this.
I am not sure but I believe that math.sqrt gives you and porper error if the sqrt is negative, and @NomsterDude 's changes could fail withou and proper error.
Hope I've helped 👍🏼

@NomsterDude

Copy link
Copy Markdown
Author

Hi guys, I was just looking some PR's to see if there was any new improvement and found this.
I am not sure but I believe that math.sqrt gives you and porper error if the sqrt is negative, and @NomsterDude 's changes could fail withou and proper error.
Hope I've helped 👍🏼

Good to know! Thanks for the reply!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants