fasm: patch ignored runtime dependency warnings#8
Open
jleightcap wants to merge 1 commit into
Open
Conversation
see: https://github.com/ngi-nix/ngipkgs/issues/7#issuecomment-1751297679 fasm provides two options for runtime parsing: `textx` and ANTLR4. ANTLR4 is: - not immediately in nixpkgs as a C++ runtime with compatible CMake hooks - not easily exposed in the fasm build scripts. There is an Arch Linux specific workaround on an unmerged branch. For the time being, fall back to the flower `textx` parser and patch out the runtime warning: ``` RuntimeWarning: Unable to import fast Antlr4 parser implementation. ImportError: cannot import name tags Falling back to the much slower pure Python textX based parser implementation. Getting the faster antlr parser can normally be done by installing the required dependencies and then reinstalling the fasm package with: pip uninstall pip install -v fasm warn( ``` Thanks for the tip fricklerhandwerk! Signed-off-by: Jack Leightcap <jack@leightcap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see:
ngi-nix/projects#5 (comment)
fasm provides two options for runtime parsing:
textxand ANTLR4.ANTLR4 is:
hooks
There is an Arch Linux specific workaround on an unmerged branch.
For the time being, fall back to the flower
textxparser and patch outthe runtime warning:
Thanks for the tip @fricklerhandwerk!
Signed-off-by: Jack Leightcap jack@leightcap.com