Skip to content

Move remaining /api/device routes to /api/boxes#799

Merged
jona159 merged 9 commits intodevfrom
fix/boxes-api-routes
Mar 4, 2026
Merged

Move remaining /api/device routes to /api/boxes#799
jona159 merged 9 commits intodevfrom
fix/boxes-api-routes

Conversation

@scheidtdav
Copy link
Member

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Technically a breaking change compared to the version in this repository but actually required to be backwards compatible with the "old" osem.

Essentially I only moved code around.
The only thing missing was for the zod schema when creating boxes, I had to add the ability to provide a location object in addition to the already existing location array.

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

@scheidtdav scheidtdav requested a review from jona159 March 4, 2026 14:49
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.55% 1665 / 2327
🔵 Statements 69.87% 1742 / 2493
🔵 Functions 73.16% 338 / 462
🔵 Branches 58.64% 923 / 1574
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/lib/devices-service.server.ts 60.37% 50% 66.66% 59.57% 90-91, 101, 110-113, 124-141, 149, 169-174, 202-203, 223-226
app/routes/api.boxes.ts 90.47% 100% 100% 90.47% 393-394, 451-452
Generated in workflow #2132 for commit 0a0c175 by the Vitest Coverage Report Action

@jona159 jona159 merged commit 7f15661 into dev Mar 4, 2026
6 checks passed
@jona159 jona159 deleted the fix/boxes-api-routes branch March 4, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants