refactor: add support for Qt6 - #36
Merged
Merged
Conversation
- use QList instead of QLinkedList - use QRegularExpression instead of QRegExp - use QScreen instead of QDesktopWidget Others: - remove #include <sys/sysctl.h> (see also PR openSUSE#28) - fix: leave loop in Platform::removeDeviceFromList when item found as erase invalidates iterator Note: these changes break compatibility with Qt4 Signed-off-by: letsfindaway <me@letsfindaway.de>
Member
|
This project needs to be ported from qmake to cmake too, as qmake is deprecated now. |
|
@Conan-Kudo I created issue #37 for this. I can have a look and will propose a pull request. Back to topic: This pull request fixes the compilation on Tumbleweed with Qt 6 for me. |
Conan-Kudo
approved these changes
May 30, 2025
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables compilation of Imagewriter with Qt6.
QListinstead ofQLinkedListQRegularExpressioninstead ofQRegExpQScreeninstead ofQDesktopWidgetOthers:
#include <sys/sysctl.h>(see also PR remove include <sys/sysctl.h> #28)Platform::removeDeviceFromListwhen item found aseraseinvalidates iteratorNote: these changes break compatibility with Qt4
Note: in End of Qt 5 support the Imagewriter is listed as "unmaintained". I hope this PR will allow us to continue including Imagewriter in TW and Leap 16.