Skip to content

869 bug choices parameter for textfields on spell model have no effect#930

Open
augustjohnson wants to merge 2 commits into
stagingfrom
869-bug-choices-parameter-for-textfields-on-spell-model-have-no-effect
Open

869 bug choices parameter for textfields on spell model have no effect#930
augustjohnson wants to merge 2 commits into
stagingfrom
869-bug-choices-parameter-for-textfields-on-spell-model-have-no-effect

Conversation

@augustjohnson
Copy link
Copy Markdown
Collaborator

Here's roughly what I did:

  • Allowed spells to be nullable, due to empty data in spells-that-dont-suck.
  • Added a validation method into import that that checks choice constraints on models, it should fail now on bad choices.
  • Fixed a ton of spells with invalid casting_times, across srd-2024 and spells-that-dont-suck. I anticipate there remain some problems there, but the basics are within choices OR are null at this point, that's pretty good.
  • Added some tests for the fields that were untested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] choices parameter for TextFields on Spell model have no effect

1 participant