Repository navigation
fix(metrics): apply default view when no user view matches - #54
Closed
xavierroma wants to merge 1 commit into
Closed
xavierroma wants to merge 1 commit into
xavierroma wants to merge 1 commit into
Conversation
xavierroma
requested review from
ArielDemarco,
bryce-b,
nachoBonafonte and
vvydier
as code owners
April 17, 2026 02:23
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage ? 69.20%
=======================================
Files ? 231
Lines ? 8059
Branches ? 0
=======================================
Hits ? 5577
Misses ? 2482
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
@nachoBonafonte anything I can help with to get this merged? |
Member
|
The approach is being evaluated, we are not sure this is what the spec expects. |
Member
|
This looks good to me |
bryce-b
approved these changes
May 20, 2026
Member
|
@xavierroma can you rebase main; I believe recent dependency updates will with the build failures. |
bryce-b
marked this pull request as draft
May 21, 2026 16:38
bryce-b
marked this pull request as ready for review
May 21, 2026 16:38
bryce-b
enabled auto-merge (squash)
June 4, 2026 16:15
bryce-b
marked this pull request as draft
June 4, 2026 16:15
auto-merge was automatically disabled
June 4, 2026 16:15
Pull request was converted to draft
bryce-b
marked this pull request as ready for review
June 4, 2026 16:16
Member
|
@xavierroma we'd like to merge this but this pr requires a rebase to rebuild the build checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
ViewRegistry.findViews never consulted instrumentDefaultRegisteredView, so with no user registered views every record silently dispatched to zero storages and nothing was exported.
Fix:
Fall back to the per instrument default view when no user view matches.
Metrics SDK – Measurement processing: If the MeterProvider has no View registered, take the Instrument and apply the default Aggregation on the basis of instrument kind according ...