Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 25, 2025

Which problem is this PR solving?

BatchLogRecordProcessorBase creates an extra wrapper Promise on each call to _flushOneBatch().

Fixes # N/A

Short description of the changes

This commit removes the extra wrapper Promise and directly returns the callWithTimeout() Promise.

Type of change

Performance refactor

How Has This Been Tested?

  • Test suite

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@cjihrig cjihrig requested a review from a team as a code owner December 25, 2025 15:25
@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.39%. Comparing base (9a55716) to head (fc1970d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6253      +/-   ##
==========================================
- Coverage   95.39%   95.39%   -0.01%     
==========================================
  Files         314      314              
  Lines        9516     9514       -2     
  Branches     2198     2198              
==========================================
- Hits         9078     9076       -2     
  Misses        438      438              
Files with missing lines Coverage Δ
...sdk-logs/src/export/BatchLogRecordProcessorBase.ts 92.92% <100.00%> (-0.15%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maryliag maryliag added this pull request to the merge queue Jan 5, 2026
Merged via the queue into open-telemetry:main with commit 9295dc9 Jan 5, 2026
27 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Jan 5, 2026

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the wrapper-promise branch January 5, 2026 15:46
@otelbot-js otelbot-js bot mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants