parseKeyPairsIntoRecord() #6230
Open
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cjihrig
reviewed
Dec 19, 2025
| it('filters out empty values', () => { | ||
| assert.deepStrictEqual(parseKeyPairsIntoRecord('key1=,key2=value2'), { | ||
| key2: 'value2', | ||
| it('prevents empty baggage values', () => { |
Contributor
There was a problem hiding this comment.
A more accurate test title might be something like: supports empty string values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR fixes an issue where parseKeyPairsIntoRecord() dropped baggage key-value pairs with empty values.
According to the W3C Baggage specification, empty values are valid, but the current implementation filtered them out during parsing. This caused valid baggage entries to be lost.
Fixes #6138
Short description of the changes
Updated parsePairKeyValue to allow empty baggage values while rejecting invalid pairs.
Ensured parseKeyPairsIntoRecord() preserves entries with empty values.
Added unit tests to cover empty baggage value handling and prevent regressions.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added unit tests for parseKeyPairsIntoRecord covering empty baggage values.
Tests were executed locally using:
npx mocha test/common/baggage/utils.test.ts
All existing and new tests pass.
Checklist: