Skip to content

Conversation

@n9te9
Copy link

@n9te9 n9te9 commented Dec 17, 2025

Background

Dice example README didn't clearly state what users can learn from this example.
As a result, first-time users may be unsure about the learning focus of the dice example.

What

This change adds a short description to clarify what this example demonstrates.

@n9te9 n9te9 requested a review from a team as a code owner December 17, 2025 09:48
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 17, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: n9te9 / name: n9te9 (7e03eec)

@dmathieu
Copy link
Member

Your statement isn't accurate. The otelhttp handler will do tracing too.

@n9te9
Copy link
Author

n9te9 commented Dec 17, 2025

@dmathieu
You're absolutely right - the otelhttp handler does create spans and performs tracing.
What I wanted to clarify in the README is not that tracing is absent, the example's primary learning focus, from a first-time user's perspective, is metrics instrumentation (for example, the custom dice.rolls metrics and exemplars).
The change is intended to make the learning intent of the example clearer, rather than to imply tracing is not involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants