-
Notifications
You must be signed in to change notification settings - Fork 725
Add linter checking we use the latest semconv version #8231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: James Thompson <[email protected]>
Co-authored-by: James Thompson <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8231 +/- ##
=====================================
Coverage 82.3% 82.3%
=====================================
Files 192 192
Lines 13777 13777
=====================================
Hits 11342 11342
Misses 2030 2030
Partials 405 405 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
Side note: I think it would be nice to have the process of bumping semconv (starting from generating new semconv) to be documented in CONTRIBUTING.md.
Yes. This seems like it should happen in core though. |
|
@open-telemetry/go-approvers this would welcome a second approval. |
I created open-telemetry/opentelemetry-go#7697 |
|
@open-telemetry/go-approvers ping for second approval :) |
This is inspired by open-telemetry/opentelemetry-collector-contrib#44606
Mongo is the only package with an older semconv. See #8230 to move forward with the upgrade.