fix: render the no-voice-API-key warning as a strip, not a full-height column - #5
Open
kon-foo wants to merge 1 commit into
Open
fix: render the no-voice-API-key warning as a strip, not a full-height column#5kon-foo wants to merge 1 commit into
kon-foo wants to merge 1 commit into
Conversation
…t column #voiceWarning was a direct child of .chat-view, a flex row, so unhiding it made it a flex item: content width, stretched to full height, taking a column of its own beside the camera and conversation panels. Move it into .panel-right, an existing flex column, where it lays out as the strip its styling describes and .conversation absorbs the height.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behaviour: When running without a voice API key
#voiceWarningis unhidden, and above 700px it covers well over a third of the chat view instead of being a small warning.Root Cause:
#voiceWarningis a direct child of.chat-view, which is a flex row. With no width set it becomes a flex item at content width, stretched to full height by the row's defaultalign-items: stretch— so it takes a column of its own beside the camera and conversation panels.Fix: Moving it into
.panel-right, which is already a flex column, renders it as a strip above the conversation.Note: As in PR #4 I couldn't run a build to verify.
npm ciandnpm installboth fail on a clean clone —package-lock.jsonresolves@open-gitagent/gitagenttofile:core.tgz, which isn't in the repo.