Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove it-test that depends on Hermes being present in OPAL. Note that the test should test the Hermes implementation from the resource file, but doesn't since ClassLoaders first resolve using their parent class loader before trying to find a class themselves. With Hermes removed from OPAL, it does indeed invoke the Hermes implementation from the resource file but that uses
this.getClass.getResourceAsStream("HermesCLI.txt")which does exist int he resource file, but is not found by the ClassLoader. This surely could be fixed, but the test doesn't seem important enough to jump through hoops.