fix: apply permissive model workaround to prevent pydantic validation errors on App Catalog SAML apps (closes #48) - #86
Open
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
… errors on App Catalog SAML apps (closes okta#48)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Multiple Pydantic
ValidationErrorfailures occur when listing or retrieving applications created from the Okta App Catalog (SAML templates) and Atlassian SWA templates. The SDK's auto-generated models enforce strict field requirements that do not match the actual API responses for these app types. A single invalid record poisons the entire response page forlist_applications,list_applicationswithq=/filter=, andget_application.Fix
Following the same pattern used for the existing
LogSecurityContextuser_behaviors workaround, we apply a monkey-patch to theApplicationmodel to make all fields optional and allow extra fields. This prevents the strict Pydantic validation from rejecting responses that contain fields not defined in the model or missing fields that the model expects. The fix ensures that all applications (regardless of template) can be returned without crashing on a single bad record.Closes #48