feat: add tools to assign users and groups to applications - #65
Open
mjdavidson wants to merge 1 commit into
Open
feat: add tools to assign users and groups to applications#65mjdavidson wants to merge 1 commit into
mjdavidson wants to merge 1 commit into
Conversation
There was no way to assign an application to a user or group, so an app built
through the server could not have anyone assigned to it — blocking any
end-to-end SSO setup that needs an assigned principal.
Add assign_user_to_app (POST /api/v1/apps/{id}/users) and assign_group_to_app
(PUT /api/v1/apps/{id}/groups/{groupId}), both gated on okta.apps.manage and
using the existing SDK client. Includes scope registry entries and README
updates.
Author
|
@manmohan-shaw-okta @BinoyOza-okta i raised a few PRs, how do I get them reviewed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no way to assign an application to a user or group, so an app built through the server could not have anyone assigned to it. Adds
assign_user_to_appandassign_group_to_app(gatedokta.apps.manage).Tests:
tests/test_app_assignment.py.