Skip to content

fix: Scan accepts text-encoded ULIDs in []byte #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsenart merged 1 commit into from
Jul 23, 2026
+11 −1
Merged

fix: Scan accepts text-encoded ULIDs in []byte #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ulid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,16 @@ func (id *ULID) Scan(src interface{}) error {
case string:
return id.UnmarshalText([]byte(x))
case []byte:
return id.UnmarshalBinary(x)
// Drivers often return text/varchar columns as []byte. Accept both
// the 16-byte binary form and the 26-character text encoding.
switch len(x) {
case len(*id):
return id.UnmarshalBinary(x)
case EncodedSize:
return id.UnmarshalText(x)
default:
return ErrDataSize
}
}

return ErrScanValue
Expand Down
1 change: 1 addition & 0 deletions ulid_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,7 @@ func TestScan(t *testing.T) {
}{
{"string", id.String(), id, nil},
{"bytes", id[:], id, nil},
{"text-as-bytes", []byte(id.String()), id, nil},
{"nil", nil, ulid.ULID{}, nil},
{"other", 44, ulid.ULID{}, ulid.ErrScanValue},
} {
Expand Down
Loading