fix(compose): restore db-migrate models mount dropped in #101 merge#108
Merged
Conversation
#100 added a ./models:/app/models:ro mount to db-migrate so the 00_initial_model_version seed can find the ONNX file. #101 edited the same db-migrate block (adding SEED_DEMO_RULES_ACTIVE) and its merge landed after #100, silently dropping the volumes mount — regressing F1. Caught by a fresh-install README walkthrough: db-migrate logged 'skipping — models/fraud_model.onnx not found', modelVersions was empty, and predict fell back to the flat 0.65 threshold. With the mount restored: model registers as default ACTIVE, 5 segment thresholds seed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression fix. #100 mounted
./modelsintodb-migrateso the initial-model seed finds the ONNX. #101 edited the same block (addingSEED_DEMO_RULES_ACTIVE) and merged after #100 — its version of the block didn't include the mount, silently reverting F1.Caught by a fresh-install README walkthrough (
down -v→up --build):db-migrateloggedskipping — models/fraud_model.onnx not found on diskmodelVersionsempty,segmentThresholdsemptyWith the mount restored and db-migrate re-run:
modelVersions=default ACTIVE,segmentThresholds= 5 rows. Verified on the live stack.Follow-up hardening worth considering (not in this PR): a CI check that fails if
db-migratelacks the./modelsmount, so this can't silently regress a third time.🤖 Generated with Claude Code