Conversation
70d483e to
48c72b5
Compare
1eec888 to
7e2885e
Compare
888401a to
112fd20
Compare
cf57908 to
5c74a2e
Compare
| // return det; | ||
| //} | ||
|
|
||
| using extrapolator_base_matrix = Eigen::Matrix<Number, Eigen::Dynamic, Eigen::Dynamic>; |
Contributor
There was a problem hiding this comment.
Multiple issues found in the Eigen integration:
- The
Numbertype is undefined but used inusing extrapolator_base_matrix = Eigen::Matrix<Number, Eigen::Dynamic, Eigen::Dynamic>; - The header file "Expression.h" is included but doesn't exist in the codebase
- The CMake configuration for Eigen is causing build failures - the repository URL
https://github.com/libeigen/eigen.gitis incorrect or inaccessible
Recommendations:
- Define the
Numbertype or use an existing type likeValuableor a numeric type - Remove the non-existent "Expression.h" include
- Fix the Eigen repository URL in CMake configuration or use vcpkg properly
| // return det; | ||
| //} | ||
|
|
||
| using extrapolator_base_matrix = Eigen::Matrix<Number, Eigen::Dynamic, Eigen::Dynamic>; |
Contributor
There was a problem hiding this comment.
The Extrapolator class has conflicting base class definitions:
// First definition
using extrapolator_base_matrix = boost::numeric::ublas::matrix<extrapolator_value_type>;
// Second definition that overwrites the first
using extrapolator_base_matrix = Eigen::Matrix<Number, Eigen::Dynamic, Eigen::Dynamic>;This creates confusion and compilation errors. You should:
- Choose one implementation (either boost::ublas or Eigen)
- If transitioning to Eigen, update all related code consistently
- Remove the commented-out code that's no longer needed
| // } | ||
| auto solution = this->llt().solve(a); | ||
| return solution.rhs(); | ||
| } |
Contributor
There was a problem hiding this comment.
The implementation of Solve method has several issues:
- There's a duplicate implementation of
Solve- one is declared but not defined, and another is defined inline - The inline implementation uses Eigen's
llt()method but returnssolution.rhs()which doesn't match the expected return type - The method doesn't handle potential errors in matrix solving
Recommendation: Consolidate the two implementations into one correct implementation that properly handles errors and returns the expected type.
4fb171a to
80a7294
Compare
50f36fd to
b2b3cf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.