fix(teams): walk ancestors to find participant name in DOM - #28
Merged
Conversation
- Move mic dedup reference state from recorder orchestration into speech. - Preserve current system-event refs and prior system-text fallback behavior. - Add focused coverage for system reference tracking semantics.
- Separate completed attribution foundation from remaining roadmap items. - Call out live validation, diagnostics, cleanup quality, dedup tuning, and test hardening as the next work areas. - Keep the detailed historical implementation notes below the status summary.
Teams' "light meetings" experience wraps some participant tiles with an extra intermediate div, placing the name data-tid at depth 2 instead of depth 1. The snapshot and poll JS expressions now walk up to 3 ancestors, skipping video-item-container elements, to find the participant name. - Previously missed ~44% of participants in meetings with mixed nesting - Added DOM fixture tests (Node.js + minimal shim) covering both patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-tidat grandparent (depth 2) instead of parent (depth 1)video-item-container-*elements, to find the participant nameTest plan
TestSnapshotJS,TestPollJS,TestSnapshotJS_SkipsShortAndLongNames) that evaluate the actual JS against both nesting patterns via Node.jsmise run buildpasses (lint, test, tidy, goreleaser check)