feat: migrate dashboard and setup components to React Query - #35
Merged
Conversation
|
@jrcity is attempting to deploy a commit to the Prisca's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR significantly refactors the application's data fetching layer by migrating away from legacy
useEffectpolling and manualfetchcalls. It introduces centralized React Query hooks across the dashboard and setup pages, ensuring better performance, automatic retries, strict typing, and substantially simplified component state management.Key Changes
QueryClientprovider insrc/main.tsxwith optimized defaults (staleTime: 5000,retry: 3,refetchOnWindowFocus: false).src/api.tswith strongly typed request/response definitions.RpcMetricsDashboard: Replaced manualsetIntervalpolling withuseQuery's built-inrefetchInterval.RateLimitDashboard: Consolidated 4 parallel fetches into cleanuseQueryhooks. Removed complexPromise.allerror handling and centralized 401 Unauthorized detection.BatchMultiCall: Replaced raw POST requests with semanticuseMutationhooks for simulate, estimate gas, validate, and optimize actions. Loading states are now smoothly derived from.isPendingflags.SetupPage: Form data is correctly populated fromuseQuery, and operations (database testing, initialization, config saving) are now handled by isolateduseMutationhooks.RpcMetricsDashboard, explicitly coveringloading,error, andsuccessstates with mocked API implementations.Motivation and Context
The previous data-fetching architecture relied heavily on component-level
useEffecthooks, leading to complex, boilerplate-heavy code prone to race conditions, memory leaks, and duplicate network requests. Leveraging@tanstack/react-queryresolves these issues natively, offering a much more maintainable and production-ready pattern.Verification
npm run lint- 0 errors)npm test- 147 tests)npm run build)Types of changes
Closes #8