fix(a11y): accessible modal dismissal (Escape, focus trap, focus return)#4
Open
ocheeluma wants to merge 1 commit into
Open
fix(a11y): accessible modal dismissal (Escape, focus trap, focus return)#4ocheeluma wants to merge 1 commit into
ocheeluma wants to merge 1 commit into
Conversation
…nnabelJoe#483) - Escape key closes the modal via document keydown listener - Focus trap: Tab/Shift+Tab cycle within dialog, never leaving it - Focus auto-moves to dialog div on open (tabIndex=-1, outline-none) - Focus returns to the triggering element on close (captured via document.activeElement in useEffect mount/unmount) - Close button aria-label updated to be dialog-specific (e.g. 'Close retire certificate dialog') for screen reader context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes AnnabelJoe#483
Changes
Both
retire-modal.tsxandtransfer-modal.tsxupdated:Escape key dismissal
useEffectwithdocument.addEventListener('keydown')— pressing Escape callsonClose().Focus trap
onKeyDownhandler on the dialog<div>intercepts Tab/Shift+Tab.Focus return
document.activeElementis captured in a ref on mount (before focus moves into the dialog).useEffect), focus is restored to the captured element.Auto-focus
tabIndex={-1}and receives.focus()on mount so keyboard position is immediately inside the modal.Close button labels
"Close"to"Close retire certificate dialog"/"Close transfer certificate dialog"for unambiguous screen reader context.Testing