fix(a11y): keyboard support for language selector#2
Open
ocheeluma wants to merge 1 commit into
Open
Conversation
…selector (AnnabelJoe#486) - Add aria-live polite region that announces language name on selection change - Add explicit <label> with htmlFor associated to the <select> element - Show full locale name in options (e.g. 'EN — English') for clarity - Remove redundant aria-label on individual <option> elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes AnnabelJoe#486
Changes
<label htmlFor="language-select">(visually hidden) associated with the<select>element viaid— satisfies semantic form markup requirement.role="status" aria-live="polite"span that announces the selected language name (e.g. "Language changed to Français") immediately after a selection change — satisfies accessible announcement requirement.EN — English) for clarity in screen readers.<select>is already keyboard-focusable and operable; no extra work needed there.Testing