Repository navigation
Add ppx_deriving-android and ppx_deriving_yojson-android - #50
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsync's core now derives its JSON codecs with
ppx_deriving_yojson, so cross-building it for Android needs the two runtime libraries (ppx_deriving.runtime,ppx_deriving_yojson.runtime) installed for the target. Neither package existed here.ppx_deriving-android.6.1.3emptiessrc/dunebefore building. That directory only holds the standalone driver executable, which linksfindlib.dynload; a cross target has no such library, and nothing built with dune uses that driver.ppx_deriving_yojson-android.3.10.0depends on the nativeppx_deriving_yojsonas well as on the Android runtime: dune runs the preprocessor in the native context, as the comment in the other ppx packages says.Tested locally: both install in a cross switch (OCaml 5.4.1, NDK API 26, macOS host), and tsync's JNI library cross-builds against them. This repository's own CI has not built them yet; this pull request is its first run.