Repository navigation
cmdliner-android: install the tool into the sysroot, not /usr/bin - #49
Merged
Merged
Conversation
The install stanza overrode LIBDIR and left BINDIR at the Makefile's default of $(PREFIX)/bin with PREFIX=/usr, so prepare-prefix creates /usr/bin and install-bin puts an aarch64-Android cmdliner binary in the host's path. Under opam's sandbox that fails outright -- install: cannot change permissions of '/usr/bin': Read-only file system -- so the package only installs where /usr happens to be writable.
toots
added a commit
to toots/tsync
that referenced
this pull request
Aug 15, 2026
The cross build wants memtrace and the android repository had no port of it, so the daemon stopped at "Library memtrace not found". ocaml-cross/opam-cross-android#48 adds one; this asks for it. The cache key goes with it, as the comment above it asks. That is not free: the restored switch is what has been carrying cmdliner-android, which does not survive a cold sandboxed install (ocaml-cross/opam-cross-android#49), so this wants that fix merged before it reaches main.
toots
added a commit
to toots/tsync
that referenced
this pull request
Aug 15, 2026
The cross build wants memtrace and the android repository had no port of it, so the daemon stopped at "Library memtrace not found". ocaml-cross/opam-cross-android#48 adds one; this asks for it. The cache key goes with it, as the comment above it asks. That is not free: the restored switch is what has been carrying cmdliner-android, which does not survive a cold sandboxed install (ocaml-cross/opam-cross-android#49), so this wants that fix merged before it reaches main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The install stanza overrides
LIBDIRand leavesBINDIRat the Makefile's default:So
prepare-prefixcreates/usr/bin, and the package is one target away from installing an aarch64-Androidcmdlinerbinary into the host's path. Under opam's sandbox it fails outright:Pointing
BINDIRat the sysroot, asLIBDIRalready is, fixes both. Verified againstocaml-android.5.4.1:opam install cmdliner-androidsucceeds where it previously failed, and/usr/binis untouched.This is easy to miss because a warm switch hides it — the package installs once wherever
/usrhappens to be writable, and every lateropam installreports it as already present. It surfaces on any cold, sandboxed install.