Optimize usage of FileDataSource with AttachmentStorage#23
Open
ganomi wants to merge 2 commits intooblac:masterfrom
Open
Optimize usage of FileDataSource with AttachmentStorage#23ganomi wants to merge 2 commits intooblac:masterfrom
ganomi wants to merge 2 commits intooblac:masterfrom
Conversation
…rce when calling .content(InputStream)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @igr,
i was optimizing the memory usage of my application and checking where humongous objects were allocated when processing emails with large attachments.
I was already using a streamed MimeMessage as input and also had configured an attachmentStorage folder. But for each attachment there was still a large byte array beeing allocated. Passing an inputStream to the .content method would always create a byte array.
So i have streamlined the usage of FileDataSource in this MR to have a minimal memory footprint.
Would be great if you could check my changes.
Best Regards
ganomi