fix: release paused flows when alert delivery fails - #903
Open
forsurprisinglyglass wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses one likely paused-flow retention path behind #873.
Root Cause
deliverAlert:reply:returns success immediately after sending the async XPC request. If that proxy fails afterward, the caller has already treated the alert as delivered, stored it inshownAlerts, and kept the flow paused. Because no reply callback fires on that path, the paused flow can remain held indefinitely.Fix
nilreply, remove the shown alert entry and resume held flows for that process keyValidation
LuLu/Tests/run_passive_mode_tests.shsuccessfully (9/9)Scope
This addresses one likely retention path from #873. I have not confirmed end-to-end that it resolves every memory-growth report behind the issue.
Fixes #873