Skip to content

go/p2p/discovery/bootstrap: Ignore private IPs#6487

Merged
peternose merged 1 commit intomasterfrom
peternose/bugfix/private-ips
Apr 9, 2026
Merged

go/p2p/discovery/bootstrap: Ignore private IPs#6487
peternose merged 1 commit intomasterfrom
peternose/bugfix/private-ips

Conversation

@peternose
Copy link
Copy Markdown
Collaborator

No description provided.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 26, 2026

Deploy Preview for oasisprotocol-oasis-core ready!

Name Link
🔨 Latest commit c76aac9
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-oasis-core/deploys/69d77acccedc30000818cb1c
😎 Deploy Preview https://deploy-preview-6487--oasisprotocol-oasis-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@peternose peternose force-pushed the peternose/bugfix/private-ips branch from 26b7991 to d53fe05 Compare March 26, 2026 11:34
@peternose peternose linked an issue Mar 26, 2026 that may be closed by this pull request
@peternose peternose force-pushed the peternose/bugfix/private-ips branch 2 times, most recently from cc291d4 to 1a896e6 Compare April 1, 2026 07:17
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 82.69231% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.15%. Comparing base (fcf368b) to head (1a896e6).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
go/p2p/discovery/bootstrap/server.go 77.50% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6487      +/-   ##
==========================================
- Coverage   64.45%   64.15%   -0.30%     
==========================================
  Files         699      699              
  Lines       68216    68228      +12     
==========================================
- Hits        43966    43773     -193     
- Misses      19187    19419     +232     
+ Partials     5063     5036      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peternose peternose marked this pull request as ready for review April 1, 2026 07:49
@peternose peternose requested review from kostko and ptrus as code owners April 1, 2026 07:49
@peternose peternose force-pushed the peternose/bugfix/private-ips branch from 1a896e6 to c76aac9 Compare April 9, 2026 10:09
@peternose peternose merged commit 51c6778 into master Apr 9, 2026
5 checks passed
@peternose peternose deleted the peternose/bugfix/private-ips branch April 9, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seed node serves private IPs

2 participants