Conversation
weixiuli
pushed a commit
to weixiuli/gluten
that referenced
this pull request
Dec 12, 2023
- Add unittests - Related to the oap-project/velox#458
zhztheplayer
force-pushed
the
update
branch
2 times, most recently
from
December 13, 2023 07:11
13e79b6 to
8a6ef2b
Compare
weixiuli
force-pushed
the
fix_bloom_filter
branch
from
December 14, 2023 03:08
87d79fe to
4cdbb77
Compare
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
JkSelf
force-pushed
the
update
branch
2 times, most recently
from
February 7, 2024 04:22
4f0b863 to
4dd1664
Compare
FelixYBW
force-pushed
the
update
branch
3 times, most recently
from
February 18, 2024 18:33
3272244 to
8b79096
Compare
FelixYBW
force-pushed
the
update
branch
3 times, most recently
from
February 23, 2024 07:16
07c9c46 to
26c8fb1
Compare
philo-he
force-pushed
the
update
branch
4 times, most recently
from
March 5, 2024 00:01
a8f7a57 to
4109261
Compare
philo-he
force-pushed
the
update
branch
8 times, most recently
from
March 12, 2024 13:37
c832f42 to
2b83c1b
Compare
GlutenPerfBot
force-pushed
the
update
branch
4 times, most recently
from
March 18, 2024 00:06
91692d4 to
0c474c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the velox BloomFilterAggregate checks the input row and throws an exception if there are some null values in the row. So we need to be consistent with spark's behavior and ignore null values.
The spark BloomFilterAggregate will Ignore null values. https://github.com/apache/spark/blob/6cdca10f148433664b3e2be6f655b0ddba817537/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/BloomFilterAggregate.scala#L180-L188