Skip to content

Fix development (and tests)#1045

Open
jhanca-robotecai wants to merge 3 commits intoo3de:developmentfrom
RobotecAI:jh/fix_build
Open

Fix development (and tests)#1045
jhanca-robotecai wants to merge 3 commits intoo3de:developmentfrom
RobotecAI:jh/fix_build

Conversation

@jhanca-robotecai
Copy link
Copy Markdown
Collaborator

@jhanca-robotecai jhanca-robotecai commented Apr 16, 2026

What does this PR do?

This PR fixes the build with the development branch of the engine:

Additionally, it fixes the tests.

Failure without the change:

[build] /home/jhanca/devroot/2610/o3de-extras/Gems/ROS2RobotImporter/Code/Tests/SdfParserTest.cpp:353:22: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
[build]         links.insert(AZStd::move(otherLinks.begin()), AZStd::move(otherLinks.end()));
[build]                      ^
[build] /home/jhanca/devroot/2610/o3de-extras/Gems/ROS2RobotImporter/Code/Tests/SdfParserTest.cpp:353:22: note: remove std::move call here
[build]         links.insert(AZStd::move(otherLinks.begin()), AZStd::move(otherLinks.end()));
[build]                      ^~~~~~~~~~~~                  ~
[build] /home/jhanca/devroot/2610/o3de-extras/Gems/ROS2RobotImporter/Code/Tests/SdfParserTest.cpp:353:55: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
[build]         links.insert(AZStd::move(otherLinks.begin()), AZStd::move(otherLinks.end()));
[build]                                                       ^
[build] /home/jhanca/devroot/2610/o3de-extras/Gems/ROS2RobotImporter/Code/Tests/SdfParserTest.cpp:353:55: note: remove std::move call here
[build]         links.insert(AZStd::move(otherLinks.begin()), AZStd::move(otherLinks.end()));
[build]                                                       ^~~~~~~~~~~~                ~
[build] 2 errors generated.


[build] /home/jhanca/devroot/2610/o3de-extras/Gems/ROS2Sensors/Code/Source/Lidar/ROS2LidarSensorComponent.cpp:205:83: error: no member named 'const_iterator' in 'std::span<float, 18446744073709551615>'
[build]         AZStd::optional<RaycastResults::FieldSpan<RaycastResultFlags::Intensity>::const_iterator> intensityIt;
[build]                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
[build] /home/jhanca/devroot/2610/o3de-extras/Gems/ROS2Sensors/Code/Source/Lidar/ROS2LidarSensorComponent.cpp:220:90: error: no member named 'const_iterator' in 'std::span<ROS2Sensors::SegmentationIds, 18446744073709551615>'
[build]         AZStd::optional<RaycastResults::FieldSpan<RaycastResultFlags::SegmentationData>::const_iterator> segDataIt;
[build]                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
[build] 2 errors generated.

How was this PR tested?

Code builds and tests pass on Ubuntu 22.04 with Humble.

Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
@jhanca-robotecai jhanca-robotecai requested review from a team as code owners April 16, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants