Qt6 add patch file for recursion check#368
Open
guillaume-haerinck wants to merge 2 commits intoo3de:mainfrom
Open
Qt6 add patch file for recursion check#368guillaume-haerinck wants to merge 2 commits intoo3de:mainfrom
guillaume-haerinck wants to merge 2 commits intoo3de:mainfrom
Conversation
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
spham-amzn
approved these changes
Mar 28, 2026
guillaume-haerinck
force-pushed
the
qt6-recursion
branch
from
5185e3f to
67c8637
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
.patchfile to prevent endless recursion when configuring QT6 in a project-centric setup.What
During the configure step, QT is looping over the subdir cmake parameter of each targets. When we build the engine alongside the project, the cmake file in the project directory will include the engine cmake, which in turn will include the project directory. In my opinion, o3de's logic is not wrong, we are just dealing with cmake restrictions and a bad design on QT side.
Further explained in discord.