Skip to content

Fix DevTools links for Node module stack frames#8352

Open
apples-kksk wants to merge 1 commit into
nwjs:mainfrom
apples-kksk:fix-devtools-node-stack-links
Open

Fix DevTools links for Node module stack frames#8352
apples-kksk wants to merge 1 commit into
nwjs:mainfrom
apples-kksk:fix-devtools-node-stack-links

Conversation

@apples-kksk
Copy link
Copy Markdown

@apples-kksk apples-kksk commented May 16, 2026

Summary:

  • Convert raw POSIX and Windows absolute paths to file:// URLs when DevTools openInNewTab() cannot parse them as URLs.
  • Leave Node stack frame filenames unchanged.
  • Add a browser test for clicking a console link from a Node CommonJS module stack frame.

Fixes #4269

Test:

  • git diff --check
  • git apply --check -p0 patch/patches/devtools.patch against DevTools frontend revision 6efd6eb1d85fd67fdcc2385c54fa56c524bec3f7
  • checked POSIX and Windows absolute path conversion with Node.js

I could not run the full NW.js browser test locally because it requires a Chromium/NW.js build output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.13 beta4 - devtools / source not found when clicking links from console

1 participant