Skip to content

Remove UserSettings From Engine #873

Closed

Description

@CharliePoole

In TestCentric/TestCentric-Gui#580 we agreed that both projects would drop user settings from their engines for compatibility. Handling settings is application-specific. This change is breaking.

Activity

  1. added this to the 4.0 milestone on Jan 20, 2021
  2. CharliePoole commented on Jan 30, 2021

    @CharliePoole
    MemberAuthor

    This is ready to work on but we need to decide how to handle user settings. In the GUI, I handled them by continuing to use the same XML settings file, moving the code out of the engine to the GUI Model. We could do something similar here or we could use a different approach for saving settings. @ChrisMaddock What do you think?

  3. ChrisMaddock commented on Feb 1, 2021

    @ChrisMaddock
    Contributor

    What do we actually save in the settings? I thought it was unused.

  4. CharliePoole commented on Feb 1, 2021

    @CharliePoole
    MemberAuthor

    It's only used indirectly in the console runner - by the RecentFilesService. So I guess RecentFiles is what really needs to be replaced. I would lean towards placing it by somethings simple, preferably by a standard approach used by other apps. Once that's done, then there's no more use of UserSettings.

  5. self-assigned this
    on Feb 10, 2021
  6. ChrisMaddock commented on Feb 13, 2021

    @ChrisMaddock
    Contributor

    What does the console do with RecentFilesService?

    I guess it depends on the use-case how we replace it - but I can't particularly think what it would be needed for...

  7. CharliePoole commented on Feb 13, 2021

    @CharliePoole
    MemberAuthor

    Turns out I was wrong... UserSettings and RecentFiles both are only used by their tests.

  8. CharliePoole commented on Feb 13, 2021

    @CharliePoole
    MemberAuthor

    Blocked by #896

  9. CharliePoole commented on Jan 21, 2022

    @CharliePoole
    MemberAuthor

    This was merged to dev-4.0 and closed. I'm reopening it so as to replicate it in main.

  10. modified the milestones: 4.0, 4.0.0-beta.1 on Dec 29, 2024
  11. added
    V4All issues related to V4 or later - use -label:V4 to get V3 issues
    on Feb 1, 2025
  12. CharliePoole commented on Jun 26, 2025

    @CharliePoole
    MemberAuthor

    This issue has been resolved in version 4.0.0-beta.1

    The release is available on:
    GitHub.
    NuGet packages are also available NuGet.org and
    Chocolatey Packages may be found at Chocolatey.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Breaking ChangeHigh PriorityV4All issues related to V4 or later - use -label:V4 to get V3 issues

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions