feat: propagate signals to launched subprocesses so that they can properly clean up resources#63
Closed
feat: propagate signals to launched subprocesses so that they can properly clean up resources#63
Conversation
7c809a0 to
403c4af
Compare
…perly clean up resources
403c4af to
2c8cd00
Compare
Member
Author
|
Superseded by #64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please let me know if there is a better way to do this, I haven't written Go in a long time.
There also seems to be some bug, but I'm not sure where the issue is coming from. If the underlying process doesn't exit, for instance after receiving SIGHUP, and we sent another signal, then
cmd.Process.Pidends up decremented by one, and so we try to send the signal to the wrong process. I don't know if I'm holding something the wrong way here, or if this is a Go runtime bug. This is what I see when sending SIGHUP twice:Which is really strange, because there is no process with PID 218205, and the actual spawned process has PID 218206.