Code quality improvements - #171
Conversation
- Update code where line length was exceeded. - Add missing parameters type declarations. - Add missing property's type declarations. - Changed non-English comments to English. PHP DocBlock improvements: - Set correct argument type / return type. - Add throws tag where necessary. - Set correct parameter names. - Add missing PHP DocBlocks
|
Thanks for the cleanup work — the docblock corrections and line-length fixes are welcome. However, our verification run marks this PR as broken, so it needs further testing before it can be merged. The property type declarations change runtime behaviour. Checking out this branch and The three errors: These are real-world UBL documents ( Root causes:
Additional points, not fatal but worth addressing:
Separately, and regardless of this PR: renaming Happy to re-run the verification once the type declarations are adjusted. |
An implicitly nullable parameter is deprecated in PHP 8.4.
# Conflicts: # composer.json
|
Thank you for your verification. I've done some further improvements, in order to get all tests green. The The All other remarks are resolved in new commits in this PR. I'm happy to do additional changes when needed. |
Added some improvements in the codebase, most are resolved warnings from PhpStorm.
PHP DocBlock improvements: