✨ VNF-3903 Add support for system update rollback and change plan actions in load balancer - #56
Open
KobayashiNozomi wants to merge 2 commits into
Open
Conversation
…ions in load balancer
yamashita-hiroto
approved these changes
Aug 14, 2026
There was a problem hiding this comment.
LGTM
- 以下パラメータの追加
- ActionLB での system-update の rollback
- ActionLB での change-plan および plan_id
- SystemUpdate の request 時の query パラメータおよび response に is_rollback_allowed を追加
- SystemUpdate の rollback および change-plan を実行する LoadBalancer のテストケースを追加
- plan_id は mock のレスポンスであるだけなので、既存で使っているものと変える必要はない認識
- v2,v3,v4 で修正内容は共通
Contributor
There was a problem hiding this comment.
VNF-3903 のレビューです。
Day 5 の API 差分を mVNA API リファレンスの x-release: 5 と突き合わせ、次のとおり対応漏れが無いことを確認しました。
API リファレンスの x-release: 5 |
対応状況 |
|---|---|
LoadBalancerAction の system-update.rollback |
対応済み |
LoadBalancerAction の change-plan.plan_id |
対応済み |
SystemUpdate.is_rollback_allowed (レスポンス) |
対応済み |
is_rollback_allowed (List のクエリ) |
対応済み |
OperationWithRequestBody の change-plan |
Operation.RequestBody が map[string]interface{} のため対応不要 |
SystemUpdateAction.rollback |
同上 |
SystemUpdateCreate / SystemUpdateUpdate の is_rollback_allowed |
Admin only のため対象外 |
v2 / v3 / v4 のすべてに反映されています。
リポジトリルートの ecl/ には managed_load_balancer が無いため、こちらは対象外です。
実装に問題は見つかりませんでした。
以下は NITS のみです。
[NITS] doc.go の追記例の桁を揃える
v2 / v3 / v4 の ecl/managed_load_balancer/v1/load_balancers/doc.go で、追記された例の Rollback: の位置が周囲の例と揃っていません。
doc comment 内のコードブロックなので、gofmt では整形されません。
rollback := true
systemUpdate := load_balancers.ActionOptsSystemUpdate{
SystemUpdateID: "31746df7-92f9-4b5e-ad05-59f6684a54eb",
- Rollback: &rollback,
+ Rollback: &rollback,
}
KobayashiNozomi
commented
Aug 21, 2026
| rollback := true | ||
| systemUpdate := load_balancers.ActionOptsSystemUpdate{ | ||
| SystemUpdateID: "31746df7-92f9-4b5e-ad05-59f6684a54eb", | ||
| Rollback: &rollback, |
Contributor
Author
There was a problem hiding this comment.
[NITS] doc.go の追記例の桁を揃える
修正しました
KobayashiNozomi
force-pushed
the
feature/VNF-3903_mlb_day5
branch
from
August 21, 2026 06:04
6cd3bc4 to
74cc9a4
Compare
KobayashiNozomi
commented
Aug 21, 2026
| rollback := true | ||
| systemUpdate := load_balancers.ActionOptsSystemUpdate{ | ||
| SystemUpdateID: "31746df7-92f9-4b5e-ad05-59f6684a54eb", | ||
| Rollback: &rollback, |
Contributor
Author
There was a problem hiding this comment.
[NITS] doc.go の追記例の桁を揃える
修正しました
KobayashiNozomi
commented
Aug 21, 2026
| rollback := true | ||
| systemUpdate := load_balancers.ActionOptsSystemUpdate{ | ||
| SystemUpdateID: "31746df7-92f9-4b5e-ad05-59f6684a54eb", | ||
| Rollback: &rollback, |
Contributor
Author
There was a problem hiding this comment.
[NITS] doc.go の追記例の桁を揃える
修正しました
KobayashiNozomi
force-pushed
the
feature/VNF-3903_mlb_day5
branch
from
August 21, 2026 08:38
74cc9a4 to
d5ee945
Compare
hico-horiuchi
left a comment
hico-horiuchi
left a comment
Contributor
There was a problem hiding this comment.
d5ee945 で v2 / v3 / v4 の 3 ファイルとも桁が揃ったことを確認しました。
対応ありがとうございます。私からは以上です。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request supports Managed Load Balancer Day 5.
Reference
nttcom/terraform-provider-ecl#142
Related Pull Requests
Test Results
v2
v3
v4